fix: remove warnings

merge-requests/342/head
Timo Kösters 2 years ago
parent 2808dd2000
commit df4c38cb61
No known key found for this signature in database
GPG Key ID: 24DA7517711A2BA4

@ -18,7 +18,7 @@ use ruma::{
events::{ events::{
room::member::{MembershipState, RoomMemberEventContent}, room::member::{MembershipState, RoomMemberEventContent},
room::message::RoomMessageEventContent, room::message::RoomMessageEventContent,
GlobalAccountDataEventType, RoomAccountDataEventType, RoomEventType, GlobalAccountDataEventType, RoomEventType,
}, },
push, UserId, push, UserId,
}; };

@ -1,7 +1,7 @@
use crate::{database::DatabaseGuard, Error, Result, Ruma}; use crate::{database::DatabaseGuard, Error, Result, Ruma};
use ruma::{ use ruma::{
api::client::{context::get_context, error::ErrorKind, filter::LazyLoadOptions}, api::client::{context::get_context, error::ErrorKind, filter::LazyLoadOptions},
events::{EventType, StateEventType}, events::StateEventType,
}; };
use std::{collections::HashSet, convert::TryFrom}; use std::{collections::HashSet, convert::TryFrom};
use tracing::error; use tracing::error;

@ -828,14 +828,6 @@ pub(crate) async fn invite_helper<'a>(
}) })
.transpose()?; .transpose()?;
let create_prev_event = if prev_events.len() == 1
&& Some(&prev_events[0]) == create_event.as_ref().map(|c| &c.event_id)
{
create_event
} else {
None
};
// If there was no create event yet, assume we are creating a version 6 room right now // If there was no create event yet, assume we are creating a version 6 room right now
let room_version_id = create_event_content let room_version_id = create_event_content
.map_or(RoomVersionId::V6, |create_event| create_event.room_version); .map_or(RoomVersionId::V6, |create_event| create_event.room_version);

@ -8,9 +8,7 @@ use ruma::{
set_pushrule_enabled, RuleKind, set_pushrule_enabled, RuleKind,
}, },
}, },
events::{ events::{push_rules::PushRulesEvent, GlobalAccountDataEventType},
push_rules::PushRulesEvent, EventType, GlobalAccountDataEventType, RoomAccountDataEventType,
},
push::{ConditionalPushRuleInit, PatternedPushRuleInit, SimplePushRuleInit}, push::{ConditionalPushRuleInit, PatternedPushRuleInit, SimplePushRuleInit},
}; };

@ -13,7 +13,7 @@ use ruma::{
canonical_alias::RoomCanonicalAliasEventContent, canonical_alias::RoomCanonicalAliasEventContent,
history_visibility::{HistoryVisibility, RoomHistoryVisibilityEventContent}, history_visibility::{HistoryVisibility, RoomHistoryVisibilityEventContent},
}, },
AnyStateEventContent, EventType, RoomEventType, StateEventType, AnyStateEventContent, StateEventType,
}, },
serde::Raw, serde::Raw,
EventId, RoomId, UserId, EventId, RoomId, UserId,

@ -7,7 +7,7 @@ use ruma::{
}, },
events::{ events::{
room::member::{MembershipState, RoomMemberEventContent}, room::member::{MembershipState, RoomMemberEventContent},
EventType, RoomEventType, StateEventType, RoomEventType, StateEventType,
}, },
serde::Raw, serde::Raw,
DeviceId, RoomId, UserId, DeviceId, RoomId, UserId,

@ -3,7 +3,7 @@ use ruma::{
api::client::tag::{create_tag, delete_tag, get_tags}, api::client::tag::{create_tag, delete_tag, get_tags},
events::{ events::{
tag::{TagEvent, TagEventContent}, tag::{TagEvent, TagEventContent},
EventType, RoomAccountDataEventType, RoomAccountDataEventType,
}, },
}; };
use std::collections::BTreeMap; use std::collections::BTreeMap;

@ -7,7 +7,6 @@ use ruma::{
client::{error::ErrorKind, to_device::send_event_to_device}, client::{error::ErrorKind, to_device::send_event_to_device},
federation::{self, transactions::edu::DirectDeviceContent}, federation::{self, transactions::edu::DirectDeviceContent},
}, },
events::EventType,
to_device::DeviceIdOrAllDevices, to_device::DeviceIdOrAllDevices,
}; };

@ -19,7 +19,7 @@ thread_local! {
struct PreparedStatementIterator<'a> { struct PreparedStatementIterator<'a> {
pub iterator: Box<dyn Iterator<Item = TupleOfBytes> + 'a>, pub iterator: Box<dyn Iterator<Item = TupleOfBytes> + 'a>,
pub statement_ref: NonAliasingBox<rusqlite::Statement<'a>>, pub _statement_ref: NonAliasingBox<rusqlite::Statement<'a>>,
} }
impl Iterator for PreparedStatementIterator<'_> { impl Iterator for PreparedStatementIterator<'_> {
@ -184,7 +184,7 @@ impl SqliteTable {
Box::new(PreparedStatementIterator { Box::new(PreparedStatementIterator {
iterator, iterator,
statement_ref, _statement_ref: statement_ref,
}) })
} }
} }
@ -283,7 +283,7 @@ impl Tree for SqliteTable {
); );
Box::new(PreparedStatementIterator { Box::new(PreparedStatementIterator {
iterator, iterator,
statement_ref, _statement_ref: statement_ref,
}) })
} else { } else {
let statement = Box::leak(Box::new( let statement = Box::leak(Box::new(
@ -309,7 +309,7 @@ impl Tree for SqliteTable {
Box::new(PreparedStatementIterator { Box::new(PreparedStatementIterator {
iterator, iterator,
statement_ref, _statement_ref: statement_ref,
}) })
} }
} }

@ -11,7 +11,7 @@ use ruma::{
}, },
events::{ events::{
room::{name::RoomNameEventContent, power_levels::RoomPowerLevelsEventContent}, room::{name::RoomNameEventContent, power_levels::RoomPowerLevelsEventContent},
AnySyncRoomEvent, EventType, RoomEventType, StateEventType, AnySyncRoomEvent, RoomEventType, StateEventType,
}, },
push::{Action, PushConditionRoomCtx, PushFormat, Ruleset, Tweak}, push::{Action, PushConditionRoomCtx, PushFormat, Ruleset, Tweak},
serde::Raw, serde::Raw,

@ -1835,14 +1835,6 @@ impl Rooms {
}) })
.transpose()?; .transpose()?;
let create_prev_event = if prev_events.len() == 1
&& Some(&prev_events[0]) == create_event.as_ref().map(|c| &c.event_id)
{
create_event
} else {
None
};
// If there was no create event yet, assume we are creating a version 6 room right now // If there was no create event yet, assume we are creating a version 6 room right now
let room_version_id = create_event_content let room_version_id = create_event_content
.map_or(RoomVersionId::V6, |create_event| create_event.room_version); .map_or(RoomVersionId::V6, |create_event| create_event.room_version);
@ -1978,7 +1970,7 @@ impl Rooms {
self.room_servers(room_id).filter_map(|r| r.ok()).collect(); self.room_servers(room_id).filter_map(|r| r.ok()).collect();
// In case we are kicking or banning a user, we need to inform their server of the change // In case we are kicking or banning a user, we need to inform their server of the change
if pdu.kind == EventType::RoomMember { if pdu.kind == RoomEventType::RoomMember {
if let Some(state_key_uid) = &pdu if let Some(state_key_uid) = &pdu
.state_key .state_key
.as_ref() .as_ref()
@ -2001,7 +1993,7 @@ impl Rooms {
// If the RoomMember event has a non-empty state_key, it is targeted at someone. // If the RoomMember event has a non-empty state_key, it is targeted at someone.
// If it is our appservice user, we send this PDU to it. // If it is our appservice user, we send this PDU to it.
if pdu.kind == EventType::RoomMember { if pdu.kind == RoomEventType::RoomMember {
if let Some(state_key_uid) = &pdu if let Some(state_key_uid) = &pdu
.state_key .state_key
.as_ref() .as_ref()

@ -23,10 +23,7 @@ use ruma::{
OutgoingRequest, OutgoingRequest,
}, },
device_id, device_id,
events::{ events::{push_rules::PushRulesEvent, AnySyncEphemeralRoomEvent, GlobalAccountDataEventType},
push_rules::PushRulesEvent, AnySyncEphemeralRoomEvent, EventType,
GlobalAccountDataEventType,
},
push, push,
receipt::ReceiptType, receipt::ReceiptType,
uint, MilliSecondsSinceUnixEpoch, ServerName, UInt, UserId, uint, MilliSecondsSinceUnixEpoch, ServerName, UInt, UserId,

@ -1201,18 +1201,6 @@ fn handle_outlier_pdu<'a>(
return Err("Incoming event refers to wrong create event.".to_owned()); return Err("Incoming event refers to wrong create event.".to_owned());
} }
// If the previous event was the create event special rules apply
let previous_create = if incoming_pdu.auth_events.len() == 1
&& incoming_pdu.prev_events == incoming_pdu.auth_events
{
db.rooms
.get_pdu(&incoming_pdu.auth_events[0])
.map_err(|e| e.to_string())?
.filter(|maybe_create| **maybe_create == *create_event)
} else {
None
};
if !state_res::event_auth::auth_check( if !state_res::event_auth::auth_check(
&room_version, &room_version,
&incoming_pdu, &incoming_pdu,
@ -1498,18 +1486,6 @@ async fn upgrade_outlier_to_timeline_pdu(
state_at_incoming_event.expect("we always set this to some above"); state_at_incoming_event.expect("we always set this to some above");
// 11. Check the auth of the event passes based on the state of the event // 11. Check the auth of the event passes based on the state of the event
// If the previous event was the create event special rules apply
let previous_create = if incoming_pdu.auth_events.len() == 1
&& incoming_pdu.prev_events == incoming_pdu.auth_events
{
db.rooms
.get_pdu(&incoming_pdu.auth_events[0])
.map_err(|e| e.to_string())?
.filter(|maybe_create| **maybe_create == *create_event)
} else {
None
};
let check_result = state_res::event_auth::auth_check( let check_result = state_res::event_auth::auth_check(
&room_version, &room_version,
&incoming_pdu, &incoming_pdu,
@ -2635,14 +2611,6 @@ pub async fn create_join_event_template_route(
}) })
.transpose()?; .transpose()?;
let create_prev_event = if prev_events.len() == 1
&& Some(&prev_events[0]) == create_event.as_ref().map(|c| &c.event_id)
{
create_event
} else {
None
};
// If there was no create event yet, assume we are creating a version 6 room right now // If there was no create event yet, assume we are creating a version 6 room right now
let room_version_id = let room_version_id =
create_event_content.map_or(RoomVersionId::V6, |create_event| create_event.room_version); create_event_content.map_or(RoomVersionId::V6, |create_event| create_event.room_version);

Loading…
Cancel
Save